server/conn: remove EOF log #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the pd leader steps down, it will also close all connections, what's the error here? do we need to ignore it too? |
|
Any update? |
huachaohuang
force-pushed
the
huachao/remove-eof
branch
from
f1e689d
to
ff74dd1
Compare
|
If a connection is closed, the error will be "use of closed network connection". |
siddontang
reviewed
Dec 14, 2016
| if errors.Cause(err) == io.EOF { | ||
| return false | ||
| } | ||
| if strings.Contains(err.Error(), "use of closed network connection") { |
There was a problem hiding this comment.
maybe you can check the err is net.Error instead.
It's better not to check the error message directly.
There was a problem hiding this comment.
But we only want to ignore this specified error, not all of the net.Error.
There was a problem hiding this comment.
define a const var for the error message.
add test to cover this function.
|
LGTM |
|
PTAL @overvenus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EOF means the remote peer closes the connection actively, seems not a server error, we don't need to log it as error to confuse users.