pd-client: fix a data race in pd client #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
reviewed
Jun 10, 2017
pd-client/client_test.go
Outdated
| count := 10 | ||
| wg.Add(count) | ||
| for i := 0; i < count; i++ { | ||
| go func(begin chan struct{}, wg *sync.WaitGroup) { |
There was a problem hiding this comment.
Why pass begin and wg as parameters? go func() {} won't work?
There was a problem hiding this comment.
No difference. go func() {} is closure, closure is slightly poor in performance.
I'll update it here, for readability.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the defer statement,
req.startis visted after thereqobject put back to pool.This may cause data race when another goroutine get the
reqfrom pool and reset itsreq.start.