Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm/syncer : fix wrong causality key when schema has prefix index #3467

Merged
merged 3 commits into from
Nov 17, 2021
Merged

dm/syncer : fix wrong causality key when schema has prefix index #3467

merged 3 commits into from
Nov 17, 2021

Conversation

WizardXiao
Copy link
Contributor

@WizardXiao WizardXiao commented Nov 15, 2021

What problem does this PR solve?

fix wrong causality key when use prefix index. #3286

What is changed and how it works?

Causality key will use prefix index to advoid dmls divide into different work group. For example.
create table t (c1 text, c2 int unique, unique key c1(c1(3)));
insert into t values ('1234', 1) --> key is 123.c1.
insert into t values ('1235', 2) --> key is 123.c1.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

`support calculate causality key with prefix index`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2021
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Nov 16, 2021
dm/syncer/dml.go Outdated Show resolved Hide resolved
dm/syncer/dml.go Show resolved Hide resolved
@pingcap pingcap deleted a comment from ti-chi-bot Nov 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2021
@WizardXiao
Copy link
Contributor Author

/run-dm-integration-test

@WizardXiao
Copy link
Contributor Author

/run-dm-compatibility-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2021
@WizardXiao
Copy link
Contributor Author

/run-integration-test

@codecov-commenter
Copy link

Codecov Report

Merging #3467 (53bf372) into master (24030f8) will increase coverage by 0.9626%.
The diff coverage is 67.8657%.

@@               Coverage Diff                @@
##             master      #3467        +/-   ##
================================================
+ Coverage   56.5356%   57.4983%   +0.9626%     
================================================
  Files           211        233        +22     
  Lines         22798      23832      +1034     
================================================
+ Hits          12889      13703       +814     
- Misses         8598       8760       +162     
- Partials       1311       1369        +58     

@WizardXiao
Copy link
Contributor Author

/run-kafka-integration-test

@Ehco1996
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 53bf372

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2021
@WizardXiao
Copy link
Contributor Author

/run-unit-test

@lance6716
Copy link
Contributor

/run-kafka-integration-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants