Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outdate docs/ and tools/, duplicate /reparo.toml #482

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

july2993
Copy link
Contributor

What problem does this PR solve?

clean up useless file

What is changed and how it works?

  • remove outdate docs/ and tools/
  • update docs link architecture img in README.md
  • remove /reparo.toml, same file with cmd/reparo/reparo.toml

Check List

Tests

  • No code

Code changes

Side effects

elated changes

update docs link architecture img in README.md
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

README.md Outdated Show resolved Hide resolved
Co-Authored-By: july2993 <july2993@gmail.com>
@WangXiangUSTC
Copy link
Contributor

LGTM

@july2993
Copy link
Contributor Author

@kennytm PTAL

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@july2993 july2993 merged commit 4b1ad84 into master Mar 11, 2019
@july2993 july2993 deleted the hjh/clean_up4 branch March 11, 2019 05:55
july2993 added a commit that referenced this pull request Mar 20, 2019
* remove outdate docs/ and tools/

update docs link architecture img in README.md

* Update README.md

Co-Authored-By: july2993 <july2993@gmail.com>
july2993 added a commit that referenced this pull request Mar 21, 2019
* remove outdate docs/ and tools/

update docs link architecture img in README.md

* Update README.md

Co-Authored-By: july2993 <july2993@gmail.com>
july2993 added a commit that referenced this pull request Mar 25, 2019
* remove outdate docs/ and tools/

update docs link architecture img in README.md

* Update README.md

Co-Authored-By: july2993 <july2993@gmail.com>
july2993 added a commit that referenced this pull request Mar 25, 2019
* put code about read&write file together and delete useless code (#480)
* remove outdate docs/ and tools/, duplicate /reparo.toml (#482)
update docs link architecture img in README.md
* Simplify and refine code (#486)
- drainer/translator/flash.go:199:9: S1034: assigning the result of this
type assertion to a variable (switch stmt := stmt.(type)) could
eliminate the following type assertions:
- syscall.SIGKILL can't be captured
- prometheus.Handler is deprecated: Please note the issues described in
the doc comment of InstrumentHandler. You might want to consider using
promhttp.Handler instead (which is non instrumented)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants