-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove outdate docs/ and tools/, duplicate /reparo.toml #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update docs link architecture img in README.md
kennytm
reviewed
Mar 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-Authored-By: july2993 <july2993@gmail.com>
LGTM |
@kennytm PTAL |
kennytm
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
july2993
added a commit
that referenced
this pull request
Mar 20, 2019
* remove outdate docs/ and tools/ update docs link architecture img in README.md * Update README.md Co-Authored-By: july2993 <july2993@gmail.com>
july2993
added a commit
that referenced
this pull request
Mar 21, 2019
* remove outdate docs/ and tools/ update docs link architecture img in README.md * Update README.md Co-Authored-By: july2993 <july2993@gmail.com>
july2993
added a commit
that referenced
this pull request
Mar 25, 2019
* remove outdate docs/ and tools/ update docs link architecture img in README.md * Update README.md Co-Authored-By: july2993 <july2993@gmail.com>
july2993
added a commit
that referenced
this pull request
Mar 25, 2019
* put code about read&write file together and delete useless code (#480) * remove outdate docs/ and tools/, duplicate /reparo.toml (#482) update docs link architecture img in README.md * Simplify and refine code (#486) - drainer/translator/flash.go:199:9: S1034: assigning the result of this type assertion to a variable (switch stmt := stmt.(type)) could eliminate the following type assertions: - syscall.SIGKILL can't be captured - prometheus.Handler is deprecated: Please note the issues described in the doc comment of InstrumentHandler. You might want to consider using promhttp.Handler instead (which is non instrumented)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
clean up useless file
What is changed and how it works?
Check List
Tests
Code changes
Side effects
elated changes