-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shorten some default location labels #4678
Labels
enhancement
New feature or request
Comments
looks good to me~ |
@azurezyq Could you please take a look? |
I think it's more user friendly. |
LGTM |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
Is your feature request related to a problem? Please describe:
Currently, when use tidb-operator to deploy cluster in cross AZ environment, it's common to set the location-labels like
["topology.kubernetes.io/region", "topology.kubernetes.io/zone", "kubernetes.io/hostname"]
, but long label names may cause performance problems. See tikv/pd#5360 for more details.Describe the feature you'd like:
As we already support mapping
host
tokubernetes.io/hostname
in:tidb-operator/pkg/manager/member/node.go
Lines 35 to 39 in 00002ed
I think it's also useful to treat
region
andzone
in the same way:region
-->topology.kubernetes.io/region
andfailure-domain.beta.kubernetes.io/region
(for old k8s version)zone
-->topology.kubernetes.io/zone
andfailure-domain.beta.kubernetes.io/zone
(for old k8s version)So user can config both
zone
ortopology.kubernetes.io/zone
, and the effect is the same.Describe alternatives you've considered:
Teachability, Documentation, Adoption, Migration Strategy:
The text was updated successfully, but these errors were encountered: