Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-diff-inspector: support checkpoint #224

Merged
merged 65 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@WangXiangUSTC
Copy link
Member

commented Mar 26, 2019

What problem does this PR solve?

save sync-diff-inspector's checkpoint, and then can stop it and restart to continue check.

What is changed and how it works?

  1. update chunk's struct
  2. save chunk's info to downstream when check
  3. when start sync-diff-inspector, will load checkpoint information
  4. refine some code

Check List

Tests

  • Unit test
  • Manual test (stop and then restart)

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

WangXiangUSTC added some commits Mar 26, 2019

@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

/run-all-tests

@WangXiangUSTC WangXiangUSTC requested review from GregoryIan and csuzhangxc Mar 26, 2019

Show resolved Hide resolved pkg/dbutil/common.go Outdated
Show resolved Hide resolved pkg/diff/chunk.go Outdated
Show resolved Hide resolved pkg/diff/chunk.go Outdated
Show resolved Hide resolved pkg/dbutil/common.go
Show resolved Hide resolved pkg/dbutil/common.go

WangXiangUSTC added some commits Apr 3, 2019

Show resolved Hide resolved pkg/dbutil/common.go Outdated
Show resolved Hide resolved pkg/diff/checkpoint.go Outdated
Show resolved Hide resolved pkg/diff/checkpoint.go Outdated
Show resolved Hide resolved pkg/diff/checkpoint.go Outdated
Show resolved Hide resolved pkg/diff/checkpoint.go
Show resolved Hide resolved pkg/diff/chunk.go Outdated
Show resolved Hide resolved pkg/diff/diff.go
Show resolved Hide resolved pkg/diff/diff.go Outdated
Show resolved Hide resolved pkg/diff/diff.go Outdated
@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

@GregoryIan

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

LGTM

@GregoryIan GregoryIan added status/LGT1 and removed status/PTAL labels Apr 4, 2019

Show resolved Hide resolved pkg/diff/diff.go
Show resolved Hide resolved pkg/diff/diff.go Outdated
Show resolved Hide resolved pkg/diff/diff.go
@csuzhangxc
Copy link
Member

left a comment

LGTM

@csuzhangxc csuzhangxc added status/LGT2 and removed status/LGT1 labels Apr 9, 2019

@WangXiangUSTC WangXiangUSTC merged commit d9985c6 into pingcap:master Apr 9, 2019

1 check passed

idc-jenkins-ci-tidb-tools/unit-test Jenkins job succeeded.
Details

@WangXiangUSTC WangXiangUSTC deleted the WangXiangUSTC:xiang/checkpoint branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.