Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tidb version #755

Merged
merged 2 commits into from
Dec 13, 2023
Merged

bump tidb version #755

merged 2 commits into from
Dec 13, 2023

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Dec 13, 2023

What problem does this PR solve?

Issue Number: close #756

What is changed and how it works?

  • update tidb version
  • copy SubTaskConfig from DM, because DM depends on tidb-tools, tidb-tools depends on DM

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@okJiang
Copy link
Member Author

okJiang commented Dec 13, 2023

/release-note-none

Copy link

ti-chi-bot bot commented Dec 13, 2023

@asddongmen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 13, 2023
Copy link

ti-chi-bot bot commented Dec 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-13 04:21:30.90500994 +0000 UTC m=+416381.942236859: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0e38c78 into pingcap:master Dec 13, 2023
4 checks passed
@okJiang okJiang deleted the bump-tidb-version branch December 13, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*: bump tidb version
3 participants