Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration_test: use dumpling to replace mydumper #765

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jan 12, 2024

What problem does this PR solve?

Issue Number: close #762

What is changed and how it works?

use dumpling to replace mydumper

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Jan 12, 2024
@jiyfhust
Copy link

/approve

@jiyfhust
Copy link

/LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 12, 2024
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 12, 2024
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/XS and removed size/S labels Jan 12, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Jan 12, 2024

/run-integration-test

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 12, 2024
Copy link

ti-chi-bot bot commented Jan 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-12 09:22:44.578286294 +0000 UTC m=+607954.162539981: ☑️ agreed by jiyfhust.
  • 2024-01-12 10:20:06.555469025 +0000 UTC m=+611396.139722712: ✖️🔁 reset by Leavrth.
  • 2024-01-12 12:51:15.563547603 +0000 UTC m=+620465.147801275: ☑️ agreed by lyzx2001.

@purelind
Copy link

@Leavrth Need approve from people in this list https://github.com/pingcap/tidb-tools/blob/master/OWNERS#L2-L92.

@Leavrth
Copy link
Contributor Author

Leavrth commented Jan 13, 2024

/merge

Copy link

ti-chi-bot bot commented Jan 13, 2024

@Leavrth: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, jiyfhust, lyzx2001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 15, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Jan 15, 2024

/merge

Copy link

ti-chi-bot bot commented Jan 15, 2024

@Leavrth: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 26d9efe into pingcap:master Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci failed: tls version mismatch
5 participants