Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: use the wrong memory-usage value when evicting plan-cache #34613

Closed
qw4990 opened this issue May 13, 2022 · 0 comments · Fixed by #34681
Closed

planner: use the wrong memory-usage value when evicting plan-cache #34613

qw4990 opened this issue May 13, 2022 · 0 comments · Fixed by #34681
Assignees
@qw4990
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 epic/plan-cache severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@qw4990
Copy link
Contributor

qw4990 commented May 13, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

The optimizer has a memory protection strategy that if the server's memory usage is higher than a specified proportion(90% by default) the optimizer can evict the LRU plan-cache.

But when calculating the proportion, the optimizer uses a wrong formula system-mem-usage / max-tidb-mem instead of tidb-mem-usage / max-tidb-mem.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@qw4990 qw4990 added type/bug The issue is confirmed as a bug. sig/planner SIG: Planner epic/plan-cache affects-5.4 This bug affects 5.4.x versions. affects-6.0 labels May 13, 2022
@qw4990 qw4990 self-assigned this May 16, 2022
@qw4990 qw4990 mentioned this issue May 16, 2022
Closed
12 tasks
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. labels May 16, 2022
@qw4990 qw4990 mentioned this issue May 16, 2022
Closed
@keeplearning20221 keeplearning20221 mentioned this issue May 16, 2022
Merged
12 tasks
@qw4990 qw4990 added affects-5.3 This bug affects 5.3.x versions. and removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. labels May 16, 2022
ti-chi-bot pushed a commit that referenced this issue May 16, 2022
@keeplearning20221
memory, kvcache : Takes process memory,compared to server-memory-quota (
0e19c1c 
#34681)

close #34613
This was referenced May 16, 2022
Closed
Merged
Closed
ti-chi-bot pushed a commit that referenced this issue Jun 22, 2022
@ti-srebot
memory, kvcache : Takes process memory,compared to server-memory-quota (
93d79f8 
#34681) (#34693)

close #34613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qw4990 qw4990

Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 epic/plan-cache severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

memory, kvcache : Takes process memory,compared to server-memory-quota keeplearning20221/tidb
2 participants
@qw4990 @ti-chi-bot