Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce line length limits in codebase #42570

Closed
ekexium opened this issue Mar 24, 2023 · 1 comment · Fixed by #42718
Closed

Enforce line length limits in codebase #42570

ekexium opened this issue Mar 24, 2023 · 1 comment · Fixed by #42718
Assignees
@hawkingrei
Labels
type/enhancement

Comments

@ekexium
Copy link
Contributor

ekexium commented Mar 24, 2023 •
edited

Enhancement

Long lines are hard to read. And it's especially annoying in larger fonts or on smaller displays.
I suggest enabling the line length check in golangci-lint. 120 should be long enough for our code.
@hawkingrei
Copy link
Member

You can enable linter in nogo to check line length limits.

@hawkingrei hawkingrei self-assigned this Mar 31, 2023
@hawkingrei hawkingrei mentioned this issue Mar 31, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 12, 2023
@hawkingrei
linter: support lll to avoid too long line (#42718)
6122ca3 
close #42570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkingrei hawkingrei

Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

linter: support lll to avoid too long line hawkingrei/tidb
2 participants
@hawkingrei @ekexium