linter: support lll to avoid too long line #42718

hawkingrei · 2023-03-31T03:46:36Z

What problem does this PR solve?

Issue Number: close #42570

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2023-03-31T03:46:37Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

ekexium
lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

hawkingrei · 2023-04-03T02:32:36Z

/retest

hawkingrei · 2023-04-10T08:31:20Z

/retest

lance6716 · 2023-04-10T09:47:22Z

build/linter/lll/analyzer.go

+	"golang.org/x/tools/go/analysis"
+)
+
+const lllName = "lll"


what's the meaning of lll?

lll is from https://github.com/golangci/golangci-lint/blob/master/pkg/golinters/lll.go.

lance6716 · 2023-04-10T09:55:07Z

build/linter/lll/analyzer.go

+		}
+
+		for _, i := range lintIssues {
+			pass.Reportf(pass.Files[idx].Pos(), "%s:%d too long", i.Filename, i.Line)


idx comes from fileNames, but fileNames is less than pass.Files because we don't count failpoint files. Please use correct idx

lance6716 · 2023-04-10T09:59:22Z

build/linter/lll/analyzer.go

+			continue
+		}
+
+		if strings.HasPrefix(line, "import") {


can use related position of ast.File.Imports to skip import part

ekexium · 2023-04-10T10:01:08Z

build/nogo_config.json

+      "dumpling/export": "ignore export code",
+      "ddl/placement/": "ignore placement code"
+    },
+    "only_files": {


Why is it only for these directories? If the left work is for following PRs, this one should not close the issue.

Too much problem is in the TiDB repo so I have to enable the part to avoid producing more problems.

Okay. Then it should ref #42570 instead of closing it.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

hawkingrei · 2023-04-12T08:49:41Z

/merge

ti-chi-bot · 2023-04-12T08:49:45Z

This pull request has been accepted and is ready to merge.

Commit hash: d82d5f9

hawkingrei · 2023-04-12T09:46:32Z

/retest

hawkingrei · 2023-04-12T10:36:18Z

/retest

hawkingrei · 2023-04-12T11:32:11Z

/retest

hawkingrei · 2023-04-12T12:10:58Z

/retest

hawkingrei · 2023-04-12T12:30:54Z

/test all

hawkingrei · 2023-04-12T13:51:34Z

/retest

ti-chi-bot · 2023-04-14T18:19:35Z

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/build	760fd9f8c7141d231a1bf5d942ead54b02629907	link	true	`/test build`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2023

hawkingrei force-pushed the lll branch from 0014ffd to f159066 Compare March 31, 2023 03:54

ti-chi-bot removed the do-not-merge/needs-linked-issue label Mar 31, 2023

hawkingrei force-pushed the lll branch from 57a00a9 to 31a08a1 Compare April 1, 2023 06:57

ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2023

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 3, 2023

hawkingrei force-pushed the lll branch from 01d395b to 88e8edc Compare April 3, 2023 06:57

ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 3, 2023

hawkingrei force-pushed the lll branch 2 times, most recently from 1b1c341 to 451474b Compare April 6, 2023 11:23

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 6, 2023

hawkingrei force-pushed the lll branch 3 times, most recently from 760fd9f to cf7a5ce Compare April 10, 2023 06:06

hawkingrei requested review from lance6716 and ekexium April 10, 2023 09:46

lance6716 reviewed Apr 10, 2023

View reviewed changes

ekexium approved these changes Apr 10, 2023

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2023

hawkingrei added 2 commits April 12, 2023 16:16

linter: support lll to avoid too long line

eca2b7f

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

linter: support lll to avoid too long line

e639060

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

hawkingrei added 12 commits April 12, 2023 16:16

save

be8ef85

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

e8779fa

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

be5d421

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

0e5beff

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

9cf8815

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

de2acc8

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

b689015

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

49a6ec1

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

643725b

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

b17a805

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

save

cc53961

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

*: fix data race in the baseTxnContextProvider.ActivateTxn

0c65dce

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

hawkingrei force-pushed the lll branch from e0f762d to 0c65dce Compare April 12, 2023 08:17

hawkingrei added 2 commits April 12, 2023 16:35

*: fix data race in the baseTxnContextProvider.ActivateTxn

f890022

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

update

d82d5f9

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

lance6716 approved these changes Apr 12, 2023

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2023

ti-chi-bot merged commit 6122ca3 into pingcap:master Apr 12, 2023
17 checks passed

hawkingrei deleted the lll branch April 12, 2023 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linter: support lll to avoid too long line #42718

linter: support lll to avoid too long line #42718

hawkingrei commented Mar 31, 2023 •

edited

ti-chi-bot commented Mar 31, 2023 •

edited

hawkingrei commented Apr 3, 2023

hawkingrei commented Apr 10, 2023

lance6716 Apr 10, 2023

hawkingrei Apr 10, 2023

lance6716 Apr 10, 2023

hawkingrei Apr 12, 2023

lance6716 Apr 10, 2023

ekexium Apr 10, 2023

hawkingrei Apr 10, 2023

ekexium Apr 10, 2023

hawkingrei commented Apr 12, 2023

ti-chi-bot commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

ti-chi-bot commented Apr 14, 2023

linter: support lll to avoid too long line #42718

linter: support lll to avoid too long line #42718

Conversation

hawkingrei commented Mar 31, 2023 • edited

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Mar 31, 2023 • edited

hawkingrei commented Apr 3, 2023

hawkingrei commented Apr 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hawkingrei commented Apr 12, 2023

ti-chi-bot commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

hawkingrei commented Apr 12, 2023

ti-chi-bot commented Apr 14, 2023

hawkingrei commented Mar 31, 2023 •

edited

ti-chi-bot commented Mar 31, 2023 •

edited