Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EvalContext should not provide property EnableVectorizedExpression #51563

Closed
Tracked by #49090
lcwangchao opened this issue Mar 7, 2024 · 0 comments · Fixed by #51567
Closed
Tracked by #49090

EvalContext should not provide property EnableVectorizedExpression #51563

lcwangchao opened this issue Mar 7, 2024 · 0 comments · Fixed by #51567
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Mar 7, 2024 •
edited
Loading

EvalContext is defined to provide information used in the expression evaluation phase. In other words, it only provides properties used only by expressions themselves. The property EnableVectorizedExpression is determined before evaluating and it is not used by any expression internally, so we should remove it from EvalContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression: remove providing EnableVectorizedExpression in EvalContext lcwangchao/tidb
1 participant
@lcwangchao