Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't add intest tag to run benchmark #52403

Closed
YangKeao opened this issue Apr 8, 2024 · 0 comments · Fixed by #52404
Closed

don't add intest tag to run benchmark #52403

YangKeao opened this issue Apr 8, 2024 · 0 comments · Fixed by #52404
Labels
type/enhancement

Comments

@YangKeao
Copy link
Member

YangKeao commented Apr 8, 2024

Enhancement

We should allow to run benchmark without intest tags. During the refactoring of many contexts, we have added a lot of assertion. They significantly affect the performance. Therefore, I propose to allow to run benchmark without adding intest tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile, testkit: don't add intest tag for daily bench YangKeao/tidb
1 participant
@YangKeao