Makefile, testkit: don't add intest tag for daily bench #52404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #52403
Problem Summary:
The benchmark gets slower with the assertion. If we disable the
intest
tag, the performance will be back but theTestKit
will fail to initialize.What changed and how does it work?
This PR only checks the
intest
tag in testkit when the incomingt
is not*testing.B
.Check List
Tests
Run this command without
-tags intest
, it'll execute successfully.Side effects
Documentation
Release note