Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile, testkit: don't add intest tag for daily bench #52404

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Apr 8, 2024

What problem does this PR solve?

Issue Number: close #52403

Problem Summary:

The benchmark gets slower with the assertion. If we disable the intest tag, the performance will be back but the TestKit will fail to initialize.

What changed and how does it work?

This PR only checks the intest tag in testkit when the incoming t is not *testing.B.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
go test -benchmem -run=^$ -bench ^BenchmarkUnionScanRead$ github.com/pingcap/tidb/pkg/executor

Run this command without -tags intest, it'll execute successfully.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 8, 2024
Copy link

ti-chi-bot bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 8, 2024
Copy link

ti-chi-bot bot commented Apr 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-08 06:56:03.736171123 +0000 UTC m=+859025.263711661: ☑️ agreed by hawkingrei.
  • 2024-04-08 07:02:12.999511757 +0000 UTC m=+859394.527052303: ☑️ agreed by Defined2014.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Merging #52404 (f231368) into master (fdcecc4) will increase coverage by 1.2917%.
Report is 42 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52404        +/-   ##
================================================
+ Coverage   71.1889%   72.4806%   +1.2917%     
================================================
  Files          1468       1468                
  Lines        432247     439000      +6753     
================================================
+ Hits         307712     318190     +10478     
+ Misses       105335     100797      -4538     
- Partials      19200      20013       +813     
Flag Coverage Δ
integration 28.1333% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 41.6008% <ø> (+7.5023%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 3e2f2c5 into pingcap:master Apr 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't add intest tag to run benchmark
3 participants