Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: handle maketime unsigned hour overflow #10074

Merged
merged 2 commits into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@AndrewDi
Copy link
Contributor

AndrewDi commented Apr 8, 2019

What problem does this PR solve?

fix #9735

What is changed and how it works?

If hour<0 and hour is unsigned    
   then overflow should true and hour should set to max_hour

Check List

Tests

  • Unit test
@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

AndrewDi commented Apr 8, 2019

@qw4990 PTAL

@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

AndrewDi commented Apr 8, 2019

/run-all-tests

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@winoros

winoros approved these changes Apr 9, 2019

Copy link
Member

winoros left a comment

lgtm

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #10074 into master will decrease coverage by 0.0166%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10074        +/-   ##
================================================
- Coverage   78.0444%   78.0277%   -0.0167%     
================================================
  Files           404        404                
  Lines         81970      81999        +29     
================================================
+ Hits          63973      63982         +9     
- Misses        13308      13320        +12     
- Partials       4689       4697         +8
@qw4990

This comment has been minimized.

Copy link
Contributor

qw4990 commented Apr 9, 2019

/rebuild

@qw4990 qw4990 merged commit 826c299 into pingcap:master Apr 9, 2019

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@qw4990

This comment has been minimized.

Copy link
Contributor

qw4990 commented Apr 9, 2019

@AndrewDi Thanks for your contribution, could you please cherry-pick this PR to branch release-2.1.

@AndrewDi AndrewDi deleted the AndrewDi:fix_maketime_func branch Apr 9, 2019

@qw4990 qw4990 referenced this pull request Apr 10, 2019

Open

Incompatible issues about date and time functions #9717

19 of 29 tasks complete

zz-jason added a commit that referenced this pull request Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.