Makefile: add a 'make ddltest' target to generate ddltest binary #10542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @zyguan |
|
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #10542 +/- ##
===============================================
- Coverage 77.288% 77.2684% -0.0196%
===============================================
Files 413 413
Lines 86963 86976 +13
===============================================
- Hits 67212 67205 -7
- Misses 14591 14605 +14
- Partials 5160 5166 +6 |
|
/run-integration-ddl-test |
zyguan
reviewed
May 20, 2019
|
/run-all-tests |
|
/run-integration-ddl-test tidb-test=pr/719 |
db-storage
pushed a commit
to db-storage/tidb
that referenced
this pull request
May 29, 2019
zimulala
pushed a commit
to zimulala/tidb
that referenced
this pull request
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
It's easier to maintenance if we follow these rules:
tidb repo provides ddltest source code and binary
tidb-test repo provides the CI script
What is changed and how it works?
Provide
make ddltesttarget in the MakefileCheck List
Tests