executor: improve UT coverage of executor package #10728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
commented
Jun 5, 2019
| @@ -240,101 +240,6 @@ func (s *testSerialSuite) TestRecoverTableByJobID(c *C) { | |||
| c.Assert(gcEnable, Equals, false) | |||
| } | |||
|
|
|||
| func (s *testSerialSuite) TestRecoverTableByTableName(c *C) { | |||
There was a problem hiding this comment.
This UT is moved to package executor because:
- Code about this test is almost in
executor/ddl.goand - UT coverage of package
ddldoesn't decrease.
Codecov Report
@@ Coverage Diff @@
## master #10728 +/- ##
================================================
+ Coverage 79.5733% 79.6772% +0.1038%
================================================
Files 415 415
Lines 87993 87980 -13
================================================
+ Hits 70019 70100 +81
+ Misses 12793 12699 -94
Partials 5181 5181 |
Codecov Report
@@ Coverage Diff @@
## master #10728 +/- ##
================================================
+ Coverage 79.8572% 79.8935% +0.0363%
================================================
Files 415 415
Lines 88270 88310 +40
================================================
+ Hits 70490 70554 +64
+ Misses 12572 12551 -21
+ Partials 5208 5205 -3 |
|
/run-all-tests |
|
/run-all-tests |
|
/bench |
|
Bench result:
Bench topology:
|
|
/bench |
|
Bench result:
Bench topology:
|
|
/bench |
|
Bench result:
Bench topology:
|
|
Bench result:
Bench topology:
|
|
Bench result:
Bench topology:
|
|
/bench |
3 similar comments
|
/bench |
|
/bench |
|
/bench |
|
Bench result:
Bench topology:
|
qw4990
requested review from
XuHuaiyu and
winoros
and removed request for
XuHuaiyu
qw4990
force-pushed
the
exec_UT
branch
2 times, most recently
from
475a83c
to
5c92c12
Compare
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
improve UT coverage of executor package to about 82%.
What is changed and how it works?
add more tests.
Check List
Tests