Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ddl: fix race in table lock config" #10880

Closed
wants to merge 1 commit into from
Closed

Revert "ddl: fix race in table lock config" #10880

wants to merge 1 commit into from

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jun 20, 2019 •
edited
Loading

Reverts #10848
The #10855 fixes this data race, and #10848 may cause the data race that was previously repaired by #10855.

@zimulala
Copy link
Contributor Author

PTAL @coocood @tiancaiamao

@coocood
Copy link
Member

coocood commented Jun 20, 2019

LGTM

@zimulala zimulala added status/LGT1 Indicates that a PR has LGTM 1. component/test labels Jun 20, 2019
@tiancaiamao
Copy link
Contributor

Please resolve conflicts

@zimulala
Copy link
Contributor Author

It is fixed.

@zimulala zimulala closed this Jul 26, 2019
@coocood coocood deleted the revert-10848-fix-race branch February 26, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/test status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zimulala @coocood @tiancaiamao