ddl: fix ddl modify column from null to not null bug: check null value again before change to no null #10948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10948 +/- ##
================================================
- Coverage 81.0123% 81.0015% -0.0109%
================================================
Files 419 418 -1
Lines 89379 89265 -114
================================================
- Hits 72408 72306 -102
+ Misses 11749 11727 -22
- Partials 5222 5232 +10 |
crazycs520
added
type/bugfix
|
/run-all-tests |
crazycs520
changed the title
tangenta
reviewed
Jun 26, 2019
Deardrops
reviewed
Jun 28, 2019
winkyao
added
priority/release-blocker
zimulala
reviewed
Jul 2, 2019
ddl/column.go
Outdated
| if !mysql.HasNotNullFlag(oldCol.Flag) && mysql.HasNotNullFlag(newCol.Flag) && !mysql.HasPreventNullInsertFlag(oldCol.Flag) { | ||
| // Column from null to not null. | ||
| if !mysql.HasNotNullFlag(oldCol.Flag) && mysql.HasNotNullFlag(newCol.Flag) { | ||
| noPreventNullFlag := !mysql.HasPreventNullInsertFlag(oldCol.Flag) | ||
| // Introduce the `mysql.HasPreventNullInsertFlag` flag to prevent users from inserting or updating null values. | ||
| ver, err = modifyColumnFromNull2NotNull(w, t, dbInfo, tblInfo, job, oldCol, newCol) |
There was a problem hiding this comment.
It seems that if noPreventNullFlag is false, we only need to do checkForNullValue. In other words, we needn't do updateVersionAndTableInfoWithCheck. Do we change this code?
zimulala
reviewed
Jul 2, 2019
ddl/db_test.go
Outdated
| } | ||
| c2 := getModifyColumn() | ||
| if mysql.HasPreventNullInsertFlag(c2.Flag) { | ||
| _, err := s.tk.Exec("insert into t1 values ();") |
|
/run-all-tests |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Nov 18, 2019
…e again before change to no null (pingcap#10948)
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Nov 18, 2019
…e again before change to no null (pingcap#10948)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix bug of modifying column from null to not null.
Origin logic:
null -> check column null value count is 0 -> set prevent-null-flag -> not null.
The problem is after setting prevent-null-flag, but before TiDB wait schema changed, insert null will success. And we should check
check column null value count is 0again before changing tonot null.Current logic:
null -> check column null value count is 0 -> set prevent null flag -> check column null value count is 0 -> not null.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes