Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: support dynamic enable/disable plugins(#11122)(#10923)(#10506) #11189

Merged
merged 5 commits into from Jul 15, 2019
Merged

plugin: support dynamic enable/disable plugins(#11122)(#10923)(#10506) #11189

merged 5 commits into from Jul 15, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Jul 11, 2019 •
edited

cherry-pick #11122 #10923 #10506 to 2.1

This change is Reviewable

@lysu
Copy link
Collaborator Author

lysu commented Jul 11, 2019

/run-all-tests

@lysu lysu requested review from tiancaiamao and jackysp July 11, 2019 03:35
@lysu lysu added priority/release-blocker This PR blocks a release. Please review it ASAP. status/all tests passed labels Jul 11, 2019
jackysp
jackysp reviewed Jul 11, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2019
@lysu
Copy link
Collaborator Author

lysu commented Jul 15, 2019

@tiancaiamao PTAL thx

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2019
@ngaut ngaut merged commit aeed234 into pingcap:release-2.1 Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
component/plugin priority/release-blocker This PR blocks a release. Please review it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lysu @tiancaiamao @jackysp @ngaut