server: move log operation out of the lock scope #11536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bad style to print log under a lock, tiny refactor to make the code better. Lock() is also changed to RLock() to reduce lock contend
tiancaiamao
added
component/server
type/enhancement
|
PTAL @jackysp @crazycs520 |
Codecov Report
@@ Coverage Diff @@
## master #11536 +/- ##
===========================================
Coverage 81.3019% 81.3019%
===========================================
Files 425 425
Lines 91662 91662
===========================================
Hits 74523 74523
Misses 11787 11787
Partials 5352 5352 |
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
@tiancaiamao merge failed. |
|
cherry pick to release-3.0 failed |
|
It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @tiancaiamao PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Tiny refactor
What is changed and how it works?
It's a bad style to print log under a lock, tiny refactor to make the code better.
Lock() is also changed to RLock() to reduce lock contend
Check List
Tests