Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: make sleep function response to the kill statement (#10959) #12159

Merged
merged 3 commits into from
Sep 12, 2019
Merged

expression: make sleep function response to the kill statement (#10959) #12159

merged 3 commits into from
Sep 12, 2019

Conversation

tiancaiamao
Copy link
Contributor

bb7133
bb7133 reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 11, 2019
@bb7133
Copy link
Member

bb7133 commented Sep 11, 2019

/rebuild

1 similar comment
@zz-jason
Copy link
Member

/rebuild

zz-jason
zz-jason previously approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao tiancaiamao added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 11, 2019
@tiancaiamao
Copy link
Contributor Author

CI fixed @zz-jason @bb7133

jackysp
jackysp approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Sep 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit c260994 into pingcap:release-2.1 Sep 12, 2019
cosven
cosven reviewed Oct 30, 2019
View reviewed changes
expression/builtin_miscellaneous.go
finish = true
}
default:
fmt.Println("================")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 @tiancaiamao

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@tiancaiamao tiancaiamao deleted the kill-sleep-cherry branch May 26, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@jackysp jackysp jackysp approved these changes

@cosven cosven cosven left review comments

@zz-jason zz-jason zz-jason left review comments

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tiancaiamao @bb7133 @zz-jason @sre-bot @jackysp @cosven