planner: fix wrong full range for table scan in tiflash #12756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
reviewed
Oct 16, 2019
| @@ -1025,7 +1025,7 @@ func (ds *DataSource) getOriginalPhysicalTableScan(prop *property.PhysicalProper | |||
| ts.StoreType = kv.TiFlash | |||
| ts.filterCondition = append(ts.filterCondition, ts.AccessCondition...) | |||
| ts.AccessCondition = nil | |||
| ts.Ranges = ranger.FullNotNullRange() | |||
| ts.Ranges = ranger.FullIntRange(false) | |||
There was a problem hiding this comment.
Yes, TiFlash doesn't consider the unsigned situation. It only receives (-inf, +inf).
lzmhhh123
added
status/can-merge
Codecov Report
@@ Coverage Diff @@
## master #12756 +/- ##
===========================================
Coverage 79.9013% 79.9013%
===========================================
Files 462 462
Lines 105166 105166
===========================================
Hits 84029 84029
Misses 14916 14916
Partials 6221 6221 |
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As the title says.
What is changed and how it works?
Change "FullNotNullRange" to "FullIntRange".
Check List
Tests