Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: log each com_stmt_fetch separately (#11987) #12953

Merged
merged 1 commit into from
Oct 28, 2019
Merged

*: log each com_stmt_fetch separately (#11987) #12953

merged 1 commit into from
Oct 28, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Oct 28, 2019 •
edited
Loading

cherry-pick #11987 to 2.1

# Conflicts:
#	server/conn.go
#	session/tidb.go

This change is Reviewable

@lysu
*: log each com_stmt_fetch separately (#11987)
019df3f 
# Conflicts:
#	server/conn.go
#	session/tidb.go
@lysu lysu added type/enhancement The issue or PR belongs to an enhancement. priority/release-blocker This issue blocks a release. Please solve it ASAP. type/2.1 cherry-pick component/server labels Oct 28, 2019
@lysu
Copy link
Contributor Author

lysu commented Oct 28, 2019

/run-all-tests

zz-jason
zz-jason reviewed Oct 28, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2019
jackysp
jackysp approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

/run-all-tests

@sre-bot sre-bot merged commit 91080d4 into pingcap:release-2.1 Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@jackysp jackysp jackysp approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

Assignees
No one assigned
Labels
component/server priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysu @sre-bot @jackysp @zz-jason