planner: support point get by _tidb_rowid
#13360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #13360 +/- ##
===============================================
+ Coverage 80.242% 80.7053% +0.4632%
===============================================
Files 469 469
Lines 112704 114446 +1742
===============================================
+ Hits 90436 92364 +1928
+ Misses 15280 15076 -204
- Partials 6988 7006 +18 |
eurekaka
approved these changes
Nov 11, 2019
eurekaka
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 13340, 13343 |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for 12996, 13354 |
|
/run-all-tests |
|
Shall we cherry-pick this to the release branch? |
|
/merge |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Nov 13, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Nov 13, 2019
This was referenced Nov 13, 2019
sre-bot
pushed a commit
that referenced
this pull request
Nov 13, 2019
sre-bot
pushed a commit
that referenced
this pull request
Nov 13, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @lzmhhh123 PTAL. |
|
@lzmhhh123 Do we need to cherry-pick this to releaes-2.1? If not, please remove the label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As the title says.
What is changed and how it works?
When trying to build the point_get plan. Check where
_tidb_rowidcan build a point_get plan when the primary key is not the handle.Check List
Tests
Side effects