Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: update the error message of "modify/change column" to make it easier to understand (#13457) #13798

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Nov 28, 2019

Cherry-pick #13457 to v2.1
conflicts:

  • ddl/column_test.go

  • ddl/db_change_test.go

  • ddl/ddl_api.go

Release note

Update the error message of "modify/change column"

@zimulala zimulala requested review from crazycs520, bb7133 and tangenta and removed request for bb7133 and crazycs520 November 28, 2019 07:02
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 2, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/DDL-need-LGT3 status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 3, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

Your auto merge job has been accepted, waiting for 13784, 13306, 13737, 13805

@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

/run-all-tests

@sre-bot sre-bot merged commit 83919ba into pingcap:release-2.1 Dec 3, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
@zimulala zimulala deleted the modify-col-err-2.1 branch August 4, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants