-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: update the error message of "modify/change column" to make it easier to understand #13457
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13457 +/- ##
===========================================
Coverage 80.1813% 80.1813%
===========================================
Files 473 473
Lines 117470 117470
===========================================
Hits 94189 94189
Misses 15878 15878
Partials 7403 7403 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry pick to release-3.0 failed |
cherry pick to release-2.1 failed |
cherry pick to release-3.1 failed |
…sier to understand (pingcap#13457)
…sier to understand (pingcap#13457)
…sier to understand (pingcap#13457)
What problem does this PR solve?
When executing "change/modify column" we encounter some error messages as follows:
before this PR:
after this PR:
Make this error message easier to understand.
What is changed and how it works?
Check the column type before checking the charset or other information.
Check List
Tests
Related changes
Release note