Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: enhance rule partition pruning #14544

Merged
merged 3 commits into from
Jan 20, 2020
Merged

planner: enhance rule partition pruning #14544

merged 3 commits into from
Jan 20, 2020

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

fix #14539

What is changed and how it works?

Use ranger.DetachCondAndBuildRangeForIndex instead of ranger.ExtractAccessConditionsForColumn in partitionProcessor.canBePruned.
Because of that ExtractAccessConditionsForColumn only handles the scenario that the CNF/DNF only covers one column.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

release-3.0

Release note

Enhance the logical rule partition pruning to cover more scenarios.

@XuHuaiyu XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Jan 20, 2020
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner January 20, 2020 03:19
@ghost ghost requested review from winoros and removed request for a team January 20, 2020 03:19
@XuHuaiyu XuHuaiyu requested review from a team and removed request for winoros January 20, 2020 03:20
@ghost ghost requested review from lzmhhh123 and removed request for a team January 20, 2020 03:20
@XuHuaiyu XuHuaiyu requested review from a team and removed request for lzmhhh123 January 20, 2020 03:20
@ghost ghost requested review from eurekaka and removed request for a team January 20, 2020 03:20
@XuHuaiyu XuHuaiyu removed the request for review from eurekaka January 20, 2020 03:20
alivxxx
alivxxx reviewed Jan 20, 2020
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

imtbkcat
imtbkcat approved these changes Jan 20, 2020
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

@XuHuaiyu merge failed.

@XuHuaiyu XuHuaiyu merged commit a5c0d56 into pingcap:master Jan 20, 2020
@XuHuaiyu XuHuaiyu deleted the partition_prune branch January 20, 2020 03:56
@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

cherry pick to release-3.0 failed

XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Jan 20, 2020
@XuHuaiyu
planner: enhance rule partition pruning (pingcap#14544)
c41523d
@XuHuaiyu XuHuaiyu mentioned this pull request Jan 20, 2020
Merged
zz-jason pushed a commit that referenced this pull request Jan 20, 2020
@XuHuaiyu @zz-jason
planner: enhance rule partition pruning (#14544) (#14546)
8286441
@bb7133 bb7133 added this to the v4.0.0-beta.1 milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@imtbkcat imtbkcat imtbkcat approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
v4.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

unexpected partition pruning result
5 participants
@XuHuaiyu @sre-bot @imtbkcat @alivxxx @bb7133