Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle ErrTruncated when dividing decimals in non-data-change stmts #14673

Merged
merged 2 commits into from
Feb 10, 2020
Merged

expression: handle ErrTruncated when dividing decimals in non-data-change stmts #14673

merged 2 commits into from
Feb 10, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Feb 7, 2020

cherry-pick for #14438

wshwsh12
wshwsh12 reviewed Feb 7, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XuHuaiyu
XuHuaiyu approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 10, 2020

Sorry @qw4990, you don't have permission to trigger auto merge event on this branch.

@qw4990 qw4990 added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 10, 2020
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 10, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 10, 2020

@qw4990 merge failed.

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 10, 2020

/run-unit-test

@zz-jason zz-jason merged commit 45fd958 into pingcap:release-3.0 Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @sre-bot @zz-jason @XuHuaiyu @wshwsh12