Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add collation interface #14698

Merged
merged 11 commits into from
Feb 11, 2020
Merged

util: add collation interface #14698

merged 11 commits into from
Feb 11, 2020

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Feb 8, 2020 •
edited
Loading

What problem does this PR solve?

Close #14628

What is changed and how it works?

Add collation interface, and support binCollator for binary collation.

  • Note: the benchmark of collation will be added in future and in the form of tools.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

@bb7133 bb7133 added this to the v4.0.0-beta.1 milestone Feb 9, 2020
@bb7133 bb7133 self-requested a review February 9, 2020 12:13
bb7133
bb7133 reviewed Feb 9, 2020
View reviewed changes
util/collate/collate_test.go Outdated Show resolved Hide resolved
andylokandy
andylokandy previously approved these changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@andylokandy andylokandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andylokandy andylokandy self-requested a review February 9, 2020 13:12
@andylokandy
Copy link
Contributor

andylokandy commented Feb 9, 2020 •
edited
Loading

LGTM

Sorry. I intended to comment on other PR.

qw4990
qw4990 reviewed Feb 10, 2020
View reviewed changes
util/collate/collate.go Outdated Show resolved Hide resolved
@wjhuang2016
Copy link
Member Author

/rebuild

qw4990
qw4990 reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor

qw4990 commented Feb 10, 2020

/rebuild

@wjhuang2016
Copy link
Member Author

/run-all-tests

bb7133
bb7133 reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 11, 2020
@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 11, 2020
@bb7133 bb7133 added the status/can-merge Indicates a PR has been approved by a committer. label Feb 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6bae385 into pingcap:master Feb 11, 2020
@wjhuang2016 wjhuang2016 deleted the collate_basic branch November 17, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@qw4990 qw4990 qw4990 left review comments

@andylokandy andylokandy Awaiting requested review from andylokandy

@breezewish breezewish Awaiting requested review from breezewish

Assignees
No one assigned
Labels
component/util status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
v4.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

charset: define collation interface in TiDB
5 participants
@wjhuang2016 @andylokandy @qw4990 @sre-bot @bb7133