-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support more system variables in statement summary (#15508) #15682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djshow832
added
sig/execution
SIG execution
component/infoschema
type/4.0-cherry-pick
labels
Mar 25, 2020
ghost
requested a review
from XuHuaiyu
March 25, 2020 09:45
Deardrops
reviewed
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lonng
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Sorry @lonng, you don't have permission to trigger auto merge event on this branch. |
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Mar 26, 2020
/run-all-tests |
zz-jason
approved these changes
Mar 30, 2020
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/config
component/infoschema
sig/execution
SIG execution
sig/sql-infra
SIG: SQL Infra
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15508 to release-4.0
What problem does this PR solve?
Problem Summary:
max-stmt-count
andmax-sql-length
were configurations in config file, but other configurations were system variables. It's not consistent and makes many users confused.What is changed and how it works?
What's Changed:
tidb_stmt_summary_max_stmt_count
andtidb_stmt_summary_max_sql_length
.Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Check List
Tests
Side effects
N/A
Release note
tidb_stmt_summary_max_stmt_count
andtidb_stmt_summary_max_sql_length
.