planner, expression: set correct for ctx in isNullRejected #16430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
type/bug-fix
ghost
requested review from
lzmhhh123,
SunRunAway and
a team
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #16430 +/- ##
===========================================
Coverage 80.3968% 80.3968%
===========================================
Files 506 506
Lines 136570 136570
===========================================
Hits 109798 109798
Misses 18209 18209
Partials 8563 8563 |
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 16, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #16472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #16419
Problem Summary:
ctxis passed as nil wrongly for PushDownNot.What is changed and how it works?
Set the correct
ctxfor PushDownNotRelated changes
Check List
Tests
Side effects
N/A
Release note