util: build right range when where stmt only have string column. (#16645) #16658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/expression
sig/planner
wshwsh12
force-pushed
the
release-3.0-0d5a83162b58
branch
from
a95063d
to
30c0571
Compare
|
/run-all-tests |
|
/run-all-tests |
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
qw4990
added
the
priority/release-blocker
|
/run-all-tests |
|
@qw4990,Thanks for you review. |
|
/run-all-tests |
|
/rebuild |
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/run-all-tests |
|
/run-all-tests |
|
/rebuild |
|
/run-unit-test |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
bb7133
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16645 to release-3.0
What problem does this PR solve?
Issue Number: close #16505 , close #16190
Problem Summary: TableIndexScan's result is different from TableFullScan and Selection.
What is changed and how it works?
What's Changed: If the where stmt only have String column, it shouldn't be one of accessCondition to build access range. Because we should convert the string to float to check it is ture/false.
How it Works: However, revert #16135 that only cover some cases. The pr can cover all situations.
Related changes
Check List
Tests
Release note