Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: NotNullFlag is not set correctly for some expression (#16954) #16995

Merged
merged 2 commits into from
May 7, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 6, 2020

cherry-pick #16954 to release-4.0


What problem does this PR solve?

Problem Summary:
for some expression, the result type's NotNullFlag is not set correctly

What is changed and how it works?

Check and adjust type flag in AggFieldType

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Breaking backward compatibility

Release note

  • Fix wrongly set NotNullFlag for result type of functions like case when expression

@sre-bot sre-bot requested a review from a team as a code owner May 6, 2020 11:42
@sre-bot
Copy link
Contributor Author

sre-bot commented May 6, 2020

/run-all-tests

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT2 Indicates that a PR has LGTM 2. label May 7, 2020
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit a864733 into pingcap:release-4.0 May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants