*: Integrate timeline tracing with TiKV #19557

zhongzc · 2020-08-28T02:35:38Z

Signed-off-by: zhongzc zhongzc_arch@outlook.com

Getting Started

Create a Work Directory

mkdir trace-tidb && cd trace-tidb

Build TiDB

git clone -b tracing https://github.com/zhongzc/tidb --depth=1
(cd tidb && make)

Build TiKV

git clone -b new-minitrace https://github.com/zhongzc/tikv --depth=1
(cd tikv && make build)

Create Config Files

echo -e '[log]\nslow-threshold=5\n[trace]\nenable = true\njaeger-thrift-compact-agent = "127.0.0.1:6831"\ndatadog-agent = "127.0.0.1:8126"' > tidb.config

Run Jaeger

docker run --rm -d -p6831:6831/udp -p16686:16686 --name jaeger jaegertracing/all-in-one:latest

You can then navigate to http://localhost:16686 to access the Jaeger UI.

Set Up Datadog (alternative)

Follow https://docs.datadoghq.com/getting_started/tracing/

Run TiUP to Start a Cluster Locally

tiup playground v4.0.12 --db.binpath=tidb/bin/tidb-server --db.config=tidb.config --kv.binpath=tikv/target/debug/tikv-server --tiflash 0

Examples

Trace data of SQL whose cost time more than log.slow-threshold (set to 5ms above) will be recorded.

Select:

From Jaeger UI:

From Datadog UI:

Insert:

From Jaeger UI:

From Datadog UI:

Release note

TBD

sre-bot · 2020-09-04T02:17:30Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-09-04T10:34:55Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-09-09T05:48:44Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-09-09T07:11:21Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-09-09T17:38:30Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-09-09T19:44:39Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-09-10T04:38:45Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-11-24T06:51:18Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-11-24T06:55:41Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

sre-bot · 2020-11-25T15:06:25Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

Signed-off-by: zhongzc <zhongzc_arch@outlook.com> integration Signed-off-by: zhongzc <zhongzc_arch@outlook.com> support local storage Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

ti-chi-bot · 2021-02-23T04:23:10Z

@zhongzc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zhongzc · 2021-05-13T10:06:42Z

trace/reporter.go

+	curTraceID          uint64
+	curServiceName      string
+	curJTrace           *jaeger.Trace
+	curSpanIDPrefix     uint32


server/conn.go

zhongzc · 2021-06-10T06:57:11Z

server/conn.go

+		var handle minitrace.TraceHandle
+		traceEnabled := tidbtrace.Enable.Load()
+		if traceEnabled {
+			ctx, handle = minitrace.StartRootSpan(ctx, cc.packetToSQL(data), rand.Uint64(), &tidbtrace.Context{})


@c4pt0r You can replace rand.Uint64() with another meaningful trace ID here.

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

tisonkun · 2021-07-16T02:41:07Z

Closed as store/tikv moved to client-go.

Thanks for your contribution @zhongzc ! You may create another PR on both tidb and client-go for reimplementing it.

Defined2014 · 2024-01-16T09:02:51Z

Seems it's a very useful PR, I think we should support/merge it.

github-actions bot added the sig/execution SIG execution label Sep 4, 2020

github-actions bot added the component/config label Sep 9, 2020

ti-srebot added challenge-program difficulty/easy labels Sep 18, 2020

zhongzc mentioned this pull request Oct 28, 2020

*: Report tracing results to Jaeger tikv/tikv#8440

Closed

zhongzc mentioned this pull request Nov 10, 2020

*: Introduce tracing framework tikv/tikv#8981

Open

zhongzc force-pushed the tracing branch from 8ca30f0 to ea88bbd Compare November 24, 2020 06:51

zhongzc force-pushed the tracing branch from 7155615 to 98327cc Compare November 25, 2020 15:06

zhongzc force-pushed the tracing branch 11 times, most recently from 9f25358 to a085381 Compare December 2, 2020 06:07

zhongzc force-pushed the tracing branch 3 times, most recently from 18a9b5a to 8737e7e Compare January 10, 2021 10:02

zhongzc marked this pull request as ready for review January 12, 2021 14:38

zhongzc requested a review from a team as a code owner January 12, 2021 14:38

zhongzc requested review from wshwsh12 and removed request for a team January 12, 2021 14:38

introduce tracing framework

e075ac8

Signed-off-by: zhongzc <zhongzc_arch@outlook.com> integration Signed-off-by: zhongzc <zhongzc_arch@outlook.com> support local storage Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

zhongzc force-pushed the tracing branch from 8737e7e to e075ac8 Compare January 20, 2021 06:14

github-actions bot added the sig/infra label Feb 22, 2021

ti-chi-bot removed sig/infra labels Feb 22, 2021

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2021

wshwsh12 removed their request for review March 14, 2021 13:35

ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 10, 2021

zhongzc commented May 13, 2021

View reviewed changes

server/conn.go Show resolved Hide resolved

zhongzc commented Jun 10, 2021

View reviewed changes

zhongzc added 5 commits June 23, 2021 15:23

add trace id to session var

0c7bc21

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

fix kvproto

821274d

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

randomize span id prefix

cb3a18d

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

external span as parent span

9764734

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

unset trace id when finish span

239fd51

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

tisonkun closed this Jul 16, 2021

irisyou55 mentioned this pull request Jul 27, 2021

Why the pessimistic locks were executed many times within an update statement #26667

Closed

Defined2014 mentioned this pull request Feb 19, 2024

Support distributed tracing between user-application with tidb and other componentes #51144

Open

taloric mentioned this pull request Mar 6, 2024

*: add client trace info through session variable #51539

Open

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Integrate timeline tracing with TiKV #19557

*: Integrate timeline tracing with TiKV #19557

zhongzc commented Aug 28, 2020 •

edited

Loading

sre-bot commented Sep 4, 2020

sre-bot commented Sep 4, 2020

sre-bot commented Sep 9, 2020

sre-bot commented Sep 9, 2020

sre-bot commented Sep 9, 2020

sre-bot commented Sep 9, 2020

sre-bot commented Sep 10, 2020

sre-bot commented Nov 24, 2020

sre-bot commented Nov 24, 2020

sre-bot commented Nov 25, 2020

ti-chi-bot commented Feb 23, 2021

zhongzc May 13, 2021

zhongzc Jun 10, 2021

c4pt0r Jun 17, 2021

tisonkun commented Jul 16, 2021

Defined2014 commented Jan 16, 2024

*: Integrate timeline tracing with TiKV #19557

*: Integrate timeline tracing with TiKV #19557

Conversation

zhongzc commented Aug 28, 2020 • edited Loading

Getting Started

Create a Work Directory

Build TiDB

Build TiKV

Create Config Files

Run Jaeger

Set Up Datadog (alternative)

Run TiUP to Start a Cluster Locally

Examples

Release note

sre-bot commented Sep 4, 2020

sre-bot commented Sep 4, 2020

sre-bot commented Sep 9, 2020

sre-bot commented Sep 9, 2020

sre-bot commented Sep 9, 2020

sre-bot commented Sep 9, 2020

sre-bot commented Sep 10, 2020

sre-bot commented Nov 24, 2020

sre-bot commented Nov 24, 2020

sre-bot commented Nov 25, 2020

ti-chi-bot commented Feb 23, 2021

zhongzc May 13, 2021

Choose a reason for hiding this comment

zhongzc Jun 10, 2021

Choose a reason for hiding this comment

c4pt0r Jun 17, 2021

Choose a reason for hiding this comment

tisonkun commented Jul 16, 2021

Defined2014 commented Jan 16, 2024

zhongzc commented Aug 28, 2020 •

edited

Loading