-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add client trace info through session variable #51539
base: master
Are you sure you want to change the base?
Conversation
Welcome @taloric! |
Hi @taloric. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @taloric. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e9afc05
to
cc103ed
Compare
@Defined2014 hello, I've already fix all failed test, but still remain a |
/retest |
Maybe need run |
cc103ed
to
d01fa3f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51539 +/- ##
=================================================
- Coverage 72.9011% 55.9681% -16.9330%
=================================================
Files 1549 1670 +121
Lines 436313 608494 +172181
=================================================
+ Hits 318077 340563 +22486
- Misses 98726 244624 +145898
- Partials 19510 23307 +3797
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@taloric: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
/assign @wjhuang2016 @yudongusa Hello, it's been a long time but I've fixed all test cases, plz check if this issue was acceptable :) |
@taloric: GitHub didn't allow me to assign the following users: yudongusa. Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introducing a new variable needs to be approved by the PM, I'll let him check it later.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close #51144
Problem Summary:
tidb_trace_id
as session variable to log trace infos.What changed and how does it work?
tidb_trace_id
as session variable and log it intoslow_log
when a query is too slowset tidb_trace_id= xxxx
in a session, then start aspan
trace inherited from client trace id.jaeger-client-go
to v2.26.0, which supports pass tracing options fromEnvironment Variables
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
test results:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.