Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: check view recursion when building source from view (#20398) #21001

Merged
merged 5 commits into from
Nov 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20398 to release-4.0


What problem does this PR solve?

Issue Number: close #20368

Problem Summary:

create table a (a int);
create view b as select * from a;
create view c as select * from b;
drop table a;
rename table c to a;
select * from a;

TiDB server crashed with stack overflow when building source from recursive view.

What is changed and how it works?

What's Changed:

  1. Add a stack to record the views which are on building.
  2. Replace the error ErrNoSuchTable with ErrViewRecursive

How it Works:

  1. When we build source from view, we check if the view has already been on the build stack. If so, the view is defined recursively, and we return an ErrViewRecursive error.
  2. If the view is not on the stack, we push it the stack, and pop it after building.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Breaking backward compatibility. This PR makes the error message compatible with MySQL.

Release note

  • fix stack overflow when building recursive view.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@zz-jason
Copy link
Member

@francis0407 could you help to resolve the conflict?

@francis0407
Copy link
Member

@zz-jason It seems that I don't have the authority to commit on this branch https://github.com/ti-srebot/tidb/tree/release-4.0-f81a5d131412.

@SunRunAway
Copy link
Contributor

@zz-jason It seems that I don't have the authority to commit on this branch https://github.com/ti-srebot/tidb/tree/release-4.0-f81a5d131412.

@zhouqiang-cl Could you help Mingcong?

@francis0407
Copy link
Member

/run-all-tests

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21073
  • 21073
  • 21019
  • 21055
  • 20413
  • 21074
  • 21045
  • 21050
  • 21002
  • 20609

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 431e8c5 into pingcap:release-4.0 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants