*: differentiate types for user variables (#18973) #21107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ti-srebot
added
component/executor
component/expression
rewarded
sig/execution
|
@eurekaka you're already a collaborator in bot's repo. |
|
/run-all-tests |
eurekaka
force-pushed
the
release-4.0-de75e604ff2a
branch
from
db28976
to
3f52a67
Compare
|
/run-all-tests |
ti-srebot
added
status/LGT2
qw4990
previously approved these changes
Nov 25, 2020
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@ti-srebot merge failed. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
eurekaka
force-pushed
the
release-4.0-de75e604ff2a
branch
from
272dce7
to
1a1b177
Compare
qw4990
approved these changes
Nov 26, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18973 to release-4.0
What problem does this PR solve?
Issue Number: close #16820 , close #11212
#16603 and #16362 can be closed by this PR as well.
Problem Summary:
We treated all user variables as string types, so there would be cast functions added which prevent the planner to choose better plans, such as PointGet. The problem is more frequent when plan cache is enabled.
What is changed and how it works?
What's Changed:
Infer types for user variables, if the user variable is not set before, we treat it as string type. The behaviors reference https://dev.mysql.com/doc/refman/8.0/en/user-variables.html.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note