plan: support pushing agg past union all. #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Dec 2, 2016
| return agg | ||
| } | ||
|
|
||
| func (a *aggPushDownSolver) pushAggCrossUnion(agg *Aggregation, oldSchema expression.Schema, p LogicalPlan) LogicalPlan { |
There was a problem hiding this comment.
oldSchema -> unionSchema
p -> unionChild
| } else if union, ok1 := child.(*Union); ok1 { | ||
| pushedAgg := a.makeNewAgg(agg.AggFuncs, agg.groupByCols) | ||
| oldSchema := union.schema | ||
| union.SetSchema(pushedAgg.schema) |
There was a problem hiding this comment.
Maybe update union schema after push aggregate to children is better?
So we don't to define oldSchema.
|
LGTM |
zimulala
reviewed
Dec 2, 2016
| unionChild.SetParents(newAgg) | ||
| return newAgg | ||
| } | ||
|
|
||
| // aggPushDown tries to push down aggregate functions to join paths. | ||
| func (a *aggPushDownSolver) aggPushDown(p LogicalPlan) { | ||
| if agg, ok := p.(*Aggregation); ok { |
There was a problem hiding this comment.
It's better to write as follows:
agg, ok := p.(*Aggregation);
if !ok {return}
There was a problem hiding this comment.
we shouldn't return , instead, we should go to line 342
zimulala
reviewed
Dec 2, 2016
| tk.MustExec("create table t3 (c int, d int)") | ||
| tk.MustExec("insert t3 values (3, 2)") | ||
| tk.MustExec("insert t3 values (4, 3)") | ||
|
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support pushing agg past union all. This algo is very simple.
@coocood @zimulala @shenli @winoros @XuHuaiyu PTAL