-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv: export failpoints #22539
Conversation
I exposed only a little amount of them to test if it works. |
/run-tests |
@@ -587,12 +587,12 @@ func extractLockFromKeyErr(keyErr *pb.KeyError) (*Lock, error) { | |||
} | |||
|
|||
func extractKeyErr(keyErr *pb.KeyError) error { | |||
failpoint.Inject("ErrMockRetryableOnly", func(val failpoint.Value) { | |||
if val, err := MockRetryableErrorResp.Eval(); err == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it hurt performance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May cause cache miss. But in Go, i think it's not really concerned.
/run-all-tests |
1 similar comment
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to update go.mod?
executor/executor_test.go
Outdated
@@ -2400,19 +2400,19 @@ func (s *testSerialSuite) TestSplitRegionTimeout(c *C) { | |||
c.Assert(failpoint.Disable("github.com/pingcap/tidb/store/tikv/MockSplitRegionTimeout"), IsNil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use tikv.MockSplitRegionTimeout.Disable()
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@AndreMouche @disksing PTAL~ |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
What problem does this PR solve?
Issue Number: part of #22513
Problem Summary:
failpoints in
store/tikv
should be explicitly defined so as to be usable afterstore/tikv
being moved to other repository.What is changed and how it works?
What's Changed:
Added
failponit.go
instore/tikv
which contains exposed failpoints. Also, the failpoints injection is expanded manually.Check List
Tests
Release note