store/tikv: export failpoints #22539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I exposed only a little amount of them to test if it works. |
github-actions
bot
added
sig/execution
disksing
reviewed
Jan 26, 2021
disksing
previously approved these changes
Jan 27, 2021
|
/run-tests |
| @@ -587,12 +587,12 @@ func extractLockFromKeyErr(keyErr *pb.KeyError) (*Lock, error) { | |||
| } | |||
|
|
|||
| func extractKeyErr(keyErr *pb.KeyError) error { | |||
| failpoint.Inject("ErrMockRetryableOnly", func(val failpoint.Value) { | |||
| if val, err := MockRetryableErrorResp.Eval(); err == nil { | |||
There was a problem hiding this comment.
Can it hurt performance?
There was a problem hiding this comment.
May cause cache miss. But in Go, i think it's not really concerned.
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
AndreMouche
reviewed
Jan 27, 2021
executor/executor_test.go
Outdated
| @@ -2400,19 +2400,19 @@ func (s *testSerialSuite) TestSplitRegionTimeout(c *C) { | |||
| c.Assert(failpoint.Disable("github.com/pingcap/tidb/store/tikv/MockSplitRegionTimeout"), IsNil) | |||
There was a problem hiding this comment.
Could we use tikv.MockSplitRegionTimeout.Disable() instead?
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
|
@AndreMouche @disksing PTAL~ |
AndreMouche
approved these changes
Jan 27, 2021
ti-srebot
approved these changes
Jan 27, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: part of #22513
Problem Summary:
failpoints in
store/tikvshould be explicitly defined so as to be usable afterstore/tikvbeing moved to other repository.What is changed and how it works?
What's Changed:
Added
failponit.goinstore/tikvwhich contains exposed failpoints. Also, the failpoints injection is expanded manually.Check List
Tests
Release note