telemetry: add copr-cache, tiflash, cluster index, async commit #23454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
ti-chi-bot
added
the
size/XL
|
/cc @breeswish |
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
github-actions
bot
added
sig/execution
kaixu120811
reviewed
Mar 22, 2021
session/session.go
Outdated
| length := len(telemetry.CoprocessorCacheTelemetry.MinuteWindow) | ||
| if length == 0 || time.Since(*telemetry.CoprocessorCacheTelemetry.MinuteWindow[length-1].BeginAt) >= time.Minute { | ||
| var i int | ||
| for i = 0; i < length && time.Since(*telemetry.CoprocessorCacheTelemetry.MinuteWindow[i].BeginAt) >= 6*time.Hour; i++ { |
There was a problem hiding this comment.
May use some meaningful definition to instead of 6, such as TELEMETRY_UPDATE_INTERVAL ?
kaixu120811
reviewed
Mar 22, 2021
session/session.go
Outdated
| if length == 0 || time.Since(*telemetry.CoprocessorCacheTelemetry.MinuteWindow[length-1].BeginAt) >= time.Minute { | ||
| var i int | ||
| for i = 0; i < length && time.Since(*telemetry.CoprocessorCacheTelemetry.MinuteWindow[i].BeginAt) >= 6*time.Hour; i++ { | ||
| } |
There was a problem hiding this comment.
Is there any efficient way to skip the expired data? Forgive me , because I have no information about the refresh method of the telemetry verb.
There was a problem hiding this comment.
Another way is to move the logic to getTelemetryFeatureUsageInfo. It's a background thread.
kaixu120811
reviewed
Mar 22, 2021
session/session.go
Outdated
| } | ||
| if ratio >= 0.01 { | ||
| telemetry.CoprocessorCacheTelemetry.MinuteWindow[length-1].P1.Add(1) | ||
| } |
There was a problem hiding this comment.
Suggest add else to skip following un-hit check.
E.G. ratio = 0.005, we have checked ratio > 0 and ratio < 0.01, all the following check could be passed such as whether ratio >= 0.1, ratio >= 0.2, etc.
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
lzmhhh123
force-pushed
the
dev/telemetry_copr_cache
branch
from
d67710e
to
f80be36
Compare
| } | ||
|
|
||
| // async commit | ||
| stmt, err = exec.ParseWithParams(context.TODO(), `show config where name = 'storage.enable-async-apply-prewrite'`) |
There was a problem hiding this comment.
Async-commit is controlled by a session variable: tidb_enable_async_commit. You can remove codes about this part. I will add it later.
breezewish
reviewed
Mar 22, 2021
telemetry/telemetry.go
Outdated
| @@ -34,6 +34,8 @@ const ( | |||
| Prompt = "telemetry" | |||
| // ReportInterval is the interval of the report. | |||
| ReportInterval = 24 * time.Hour | |||
There was a problem hiding this comment.
Let's change it to 6 hour and change window to 1 hour~
telemetry/telemetry.go
Outdated
| @@ -34,6 +34,8 @@ const ( | |||
| Prompt = "telemetry" | |||
| // ReportInterval is the interval of the report. | |||
| ReportInterval = 24 * time.Hour | |||
| // UpdateInterval means the max time window for saved data. | |||
| UpdateInterval = 6 * time.Hour | |||
There was a problem hiding this comment.
Maybe we can call it WindowInterval for better readability?
session/session.go
Outdated
| return recordSet, nil | ||
| } | ||
|
|
||
| // CountTelemetry records the telemetry. | ||
| func CountTelemetry(s *session) { | ||
| telemetry.CoprocessorCacheTelemetry.Lock.Lock() |
There was a problem hiding this comment.
This lock seems to be very destructive.. I'm very worried about its performance.
sessionctx/variable/session.go
Outdated
| // CoprCacheHitNum is to record coprocessor cache hit times for one statement. | ||
| CoprCacheHitNum atomic2.Uint64 | ||
| // CopRespTimes is to record coprocessor response times for one statement. | ||
| CopRespTimes atomic2.Uint64 |
There was a problem hiding this comment.
Suggested change
| CopRespTimes atomic2.Uint64 | |
| CoprRespTimes atomic2.Uint64 |
By the way what is response times? Is it number of received coprocessor responses?
telemetry/data_feature_usage.go
Outdated
| // cluster index | ||
| exec := ctx.(sqlexec.RestrictedSQLExecutor) | ||
| stmt, err := exec.ParseWithParams(context.TODO(), ` | ||
| SELECT sha2(TABLE_NAME, 256) name, TIDB_PK_TYPE |
There was a problem hiding this comment.
Let's truncate it~
Suggested change
| SELECT sha2(TABLE_NAME, 256) name, TIDB_PK_TYPE | |
| SELECT left(sha2(TABLE_NAME, 256), 6) name, TIDB_PK_TYPE |
lysu
reviewed
Mar 22, 2021
|
/bench |
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: c876042
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
|
kaixu120811
reviewed
Mar 23, 2021
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
…into dev/telemetry_copr_cache
ti-chi-bot
removed
the
status/can-merge
|
/run-all-tests |
|
data race: It's not about the PR. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: e4dfe12
|
ti-chi-bot
added
the
status/can-merge
|
/run-sqllogic-test-2 |
|
/run-unit-test |
|
//run-unit-test |
|
Leak test fail: |
|
/merge |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Mar 23, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0 in PR #23489 |
SabaPing
pushed a commit
to SabaPing/tidb
that referenced
this pull request
Mar 25, 2021
lzmhhh123
pushed a commit
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lzmhhh123 lzmhhh123@gmail.com
What problem does this PR solve?
Problem Summary: as title says
What is changed and how it works?
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
admin show telemetrySide effects
Release note