*: in prepared statement limit/offset may be placeholder #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanfei1991
reviewed
Dec 31, 2016
| err error | ||
| ) | ||
| if limit.Offset != nil { | ||
| offset, err = getUintForLimitOffset(limit.Offset.GetValue()) |
There was a problem hiding this comment.
How about using evalAstExpr?
There was a problem hiding this comment.
This expr must be ConstExpr and its real value must be unsigned int.
|
LGTM |
|
@hanfei1991 PTAL |
shenli
changed the title
|
mysql> prepare ppp from "select * from t limit ?"; mysql> set @A = 1.1; mysql> execute ppp using @A; double is also ok. May be we should build a datum and cast it to int. |
shenli
force-pushed
the
shenli/issue-2180
branch
from
b8756d0
to
4143763
Compare
|
@hanfei1991 PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2180
In prepareed statement, limit/offset may be placeholder:
prepare stmt_test_1 from 'select id from prepare_test limit ? offset ?'