Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: let CopTiFlashConcurrencyFactor inflence the cost of whole plan #24157

Merged
merged 6 commits into from Apr 28, 2021

Conversation

hanfei1991
Copy link
Member

What problem does this PR solve?

Problem Summary:
Sometimes optimizer doesn't choose mpp plan. We lack a way to suggest optimizer choose mpp. I think tiflash_concurrency_factor is a good variable to charge this.

What is changed and how it works?

What's Changed:
The final mpp plan's cost will devide this factor.

How it Works:

Related changes

Check List

Tests

  • Unit test (we can detect cost changes)

Release note

  • planner: let CopTiFlashConcurrencyFactor inflence the cost of whole plan

@hanfei1991 hanfei1991 requested a review from a team as a code owner April 20, 2021 06:34
@hanfei1991 hanfei1991 requested review from XuHuaiyu and removed request for a team April 20, 2021 06:34
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 20, 2021
@hanfei1991 hanfei1991 added the sig/planner SIG: Planner label Apr 20, 2021
@@ -102,7 +102,7 @@
{
"SQL": "explain format = 'verbose' select count(*) from t2 group by a",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use brief?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verbose conflicts with brief, you cannot set them at the same time.

Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

@fzhedu: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzhedu
Copy link
Contributor

fzhedu commented Apr 23, 2021

/LGTM

@ti-chi-bot
Copy link
Member

@fzhedu: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 28, 2021
@qw4990
Copy link
Contributor

qw4990 commented Apr 28, 2021

/merge

@ti-chi-bot
Copy link
Member

@qw4990: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rebelice
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2021
@rebelice
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 429f12b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@hanfei1991
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot merged commit e79fa8c into pingcap:master Apr 28, 2021
@hanfei1991 hanfei1991 deleted the hanfei/tiflash-concur-factor branch April 28, 2021 09:02
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 8, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants