Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: planner: cherry-pick enforce-mpp to v5.0 #26378

Closed

Conversation

LittleFall
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

5.0 needs enforce-mpp.

What is changed and how it works?

cherry-pick these prs to 5.0:

  1. planner: support explain verbose mode #23926 verbose explain
  2. planner: let CopTiFlashConcurrencyFactor inflence the cost of whole plan #24157 CopTiFlashConcurrencyFactor
  3. [reverted]planner: support set tidb_allow_mpp to 2 or ENFORCE to enforce use mpp mode. #24516 support allow_mpp=2
  4. planner: Revert tidb_allow_mpp modification for downgrade compatibility and add warnings for enforce mpp. #25302 revert 24516 and support tidb_enforce_mpp and add warning
  5. planner: enforce projection push down #25450 enforce projection push down
  6. planner: Log warnings when agg function can not be pushdown in explain statement #25553 fix warning
  7. planner: add warnings about joins when tidb_enforce_mpp is enabled. #26246 add warning o fjoin

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

  • Support set tidb_enforce_mpp=1 to enforce use mpp mode.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 20, 2021
@LittleFall LittleFall changed the base branch from master to release-5.0 July 20, 2021 09:03
@LittleFall LittleFall requested review from a team as code owners July 20, 2021 09:03
@LittleFall LittleFall requested review from XuHuaiyu and removed request for a team July 20, 2021 09:03
@ti-chi-bot
Copy link
Member

@LittleFall: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jul 20, 2021
@LittleFall LittleFall closed this Jul 20, 2021
@LittleFall LittleFall deleted the cherrypick/enforce-mpp branch July 20, 2021 13:30
@LittleFall
Copy link
Contributor Author

committed by #26382

@LittleFall LittleFall changed the title planner: cherry-pick enforce-mpp to v5.0 DNM: planner: cherry-pick enforce-mpp to v5.0 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants