executor: fix data race of parallel apply operator (#24257)

[ti-srebot]

cherry-pick #24257 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24345

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24345:release-5.0-f07b62fcdfc0

---

What problem does this PR solve?

Issue Number: close #23280

Problem Summary: TestApplyGoroutinePanic test the situation of inner work panics. Sometime we got data race error. That's because:

1. Apply operator initializes, outer worker(TableReaderExecutor) starts.
2. Apply's Close() method is called by this case.
3. outExec.Close() is called.
4. Notify outer worker to finish.

Feedback info will be read in step 3. But before step 4 really works, outer worker still runs normally, it will write Feedbackinfo.

So we got data race. (Only happens on feedback, it's disabled by default.)

What is changed and how it works?

What's Changed: In Apply's Close() method, we first notify outer worker to finish and wait untill it's really finished. Then we call outer exec's Close() method.

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch

Check List

Tests: difficult to reproduce.

Side effects: no

Release note

• executor: fix data race of parallel apply operator

[ti-srebot]

/run-all-tests

[ti-srebot]

@guo-shaoge you're already a collaborator in bot's repo.

[xhebox]

/lgtm

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lzmhhh123
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[xhebox]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: cc80524

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.