Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix incorrect rows returned by TABLESAMPLE #25357

Merged
merged 7 commits into from
Jun 15, 2021

Conversation

jingshanglu
Copy link
Contributor

@jingshanglu jingshanglu commented Jun 11, 2021

What problem does this PR solve?

Issue Number: close #25257
Problem Summary:
Startup parameter --split-table=false, TableSampleExecutor does not handle the case where the end of the region is nil.

Tests

  • Unit test
  • Manual test
create table test.tsample1(id int primary key);
create table test.tsample2(id int primary key);
insert into test.tsample2 values(1);
select * from test.tsample1 tablesample regions();

Release note

  • Add the processing of region end as nil

@jingshanglu jingshanglu requested a review from a team as a code owner June 11, 2021 04:04
@jingshanglu jingshanglu requested review from wshwsh12 and removed request for a team June 11, 2021 04:04
@CLAassistant
Copy link

CLAassistant commented Jun 11, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@ti-srebot
Copy link
Contributor

@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@ti-srebot
Copy link
Contributor

@github-actions github-actions bot added the sig/execution SIG execution label Jun 11, 2021
@ichn-hu ichn-hu mentioned this pull request Jun 11, 2021
@jingshanglu jingshanglu changed the title fix tablesample return error when --split-table=false executor:fix tablesample return error when --split-table=false Jun 11, 2021
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test in sample_test.go?

@jingshanglu
Copy link
Contributor Author

Could you please add a test in sample_test.go?

ok

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@jingshanglu
Copy link
Contributor Author

/run-check_title

@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@jingshanglu jingshanglu changed the title executor:fix tablesample return error when --split-table=false executor: Fix tablesample return error when --split-table=false. (#25257) Jun 11, 2021
@jingshanglu
Copy link
Contributor Author

/run-check_title

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 12, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2021
@tangenta tangenta changed the title executor: Fix tablesample return error when --split-table=false. (#25257) executor: fix incorrect rows returned by TABLESAMPLE Jun 15, 2021
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@tangenta: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@tangenta: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tangenta tangenta added the sig/sql-infra SIG: SQL Infra label Jun 15, 2021
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 604215a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2021
@ti-chi-bot ti-chi-bot merged commit c8772c4 into pingcap:master Jun 15, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 15, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25430

@tangenta
Copy link
Contributor

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 28, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tablesample returns error result
7 participants