New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor/aggfuncs: migrate test-infra to testify for func_json_arrayagg_test.go, func_first_row_test.go, func_avg_test.go, and func_bitfuncs_test.go #28979
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
a91eff7
to
935e1ef
Compare
@@ -135,6 +142,6 @@ func (s *testSuite) TestMemJsonArrayagg(c *C) { | |||
} | |||
|
|||
for _, test := range tests { | |||
s.testAggMemFunc(c, test) | |||
testAggMemFunc(t, test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove func (s *testSuite) testAggMemFunc(c *C, p aggMemTest)
from agg_func_test.go
and refactor func_count_test.go
in my next PR, because when this PR is merged, only func_count_test.go
will call the method. However, I did not include it in this change because the change in func_count_test.go
is a bit larger :)
/cc @tisonkun |
Thanks for your contribution! I'll try to review in this week. |
Thank you for your response, I wait your review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/cc @mmyj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7bea66f
|
@budougumi0617: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #28504
Issue Number: close #28505
Issue Number: close #28508
Issue Number: close #28510
Problem Summary:
executor/aggfuncs: migrate test-infra to testify for below files
What is changed and how it works?
What's Changed:
executor/aggfuncs: migrate test-infra to testify for below files
How it Works:
All tests passed.
Release note