Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor/aggfuncs: migrate test-infra to testify for func_json_arrayagg_test.go, func_first_row_test.go, func_avg_test.go, and func_bitfuncs_test.go #28979

Merged
merged 8 commits into from Oct 27, 2021

Conversation

budougumi0617
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #28504
Issue Number: close #28505
Issue Number: close #28508
Issue Number: close #28510

Problem Summary:
executor/aggfuncs: migrate test-infra to testify for below files

  • func_json_arrayagg_test.go
  • func_first_row_test.go
  • func_avg_test.go
  • func_bitfuncs_test.go

What is changed and how it works?

What's Changed:
executor/aggfuncs: migrate test-infra to testify for below files

  • func_json_arrayagg_test.go
  • func_first_row_test.go
  • func_avg_test.go
  • func_bitfuncs_test.go

How it Works:
All tests passed.

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mmyj
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2021
@@ -135,6 +142,6 @@ func (s *testSuite) TestMemJsonArrayagg(c *C) {
}

for _, test := range tests {
s.testAggMemFunc(c, test)
testAggMemFunc(t, test)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove func (s *testSuite) testAggMemFunc(c *C, p aggMemTest) from agg_func_test.go and refactor func_count_test.go in my next PR, because when this PR is merged, only func_count_test.go will call the method. However, I did not include it in this change because the change in func_count_test.go is a bit larger :)

@budougumi0617
Copy link
Contributor Author

/cc @tisonkun

@tisonkun
Copy link
Contributor

Thanks for your contribution! I'll try to review in this week.

@budougumi0617
Copy link
Contributor Author

Thank you for your response, I wait your review :)

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

/cc @mmyj

@ti-chi-bot ti-chi-bot requested a review from mmyj October 26, 2021 14:20
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2021
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 26, 2021
@mmyj
Copy link
Member

mmyj commented Oct 27, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7bea66f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2021
@ti-chi-bot
Copy link
Member

@budougumi0617: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 077cb47 into pingcap:master Oct 27, 2021
@budougumi0617 budougumi0617 deleted the fix-issue-28510 branch October 27, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
4 participants