statistics: refactor statistics package. #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for more accurate estimation.
shenli
reviewed
Apr 12, 2017
| @@ -125,7 +125,7 @@ func (p *requiredProperty) String() string { | |||
| type physicalPlanInfo struct { | |||
| p PhysicalPlan | |||
| cost float64 | |||
| count uint64 | |||
| count float64 | |||
There was a problem hiding this comment.
We do division operation on count, integer value loses precision.
| @@ -239,3 +258,97 @@ func PseudoTable(ti *model.TableInfo) *Table { | |||
| } | |||
| return t | |||
| } | |||
|
|
|||
| func getPseudoRowCountByIndexRanges(sc *variable.StatementContext, indexRanges []*types.IndexRange, inAndEQCnt int, | |||
There was a problem hiding this comment.
Any test case for the newly added functions?
There was a problem hiding this comment.
It's not newly added, just moved from plan.
There are test cases in plan cover this.
There was a problem hiding this comment.
The current algorithm is not good, will be changed later.
We can add test cases when we change it.
alivxxx
reviewed
Apr 13, 2017
statistics/builder.go
Outdated
| } | ||
| } else if totalCount-lastCount <= valuesPerBucket { | ||
| } else if totalCount-float64(lastCount) <= valuesPerBucket { | ||
| // TODO: Making sampleFactor as float may be better. |
There was a problem hiding this comment.
sampleFactor is already float?
hanfei1991
reviewed
Apr 13, 2017
| @@ -172,8 +173,8 @@ func (t *Table) String() string { | |||
| return strings.Join(strs, "\n") | |||
| } | |||
|
|
|||
| // ColumnIsInvalid checks if this column is invalid. Exported for test. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for more accurate estimation.