Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: support 'show binding_cache status' #32567

Merged
merged 62 commits into from
Mar 15, 2022
Merged

bindinfo: support 'show binding_cache status' #32567

merged 62 commits into from
Mar 15, 2022

Conversation

Reminiscent
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #32466

Problem Summary:
Support 'show binding_cache status' to show the information about the bindCache.

What is changed and how it works?

  1. Modify the parser to support the grammar for show binding_cache status
  2. Show the "num_bindings", "total_bindings", "memory_usage", "memory_capacity" for show binding_cache status

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent
bindInfo: support the LRU for the bindCache
22d03f4
@Reminiscent
Merge branch 'master' of github.com:pingcap/tidb into bindCache
837acdc
@Reminiscent
fix ut and remove useless lock
08c1e4f
@Reminiscent
refactor
05ca0ec
@Reminiscent
add more test cases
177ea4c
@Reminiscent
revert the useless change
6e2080c
@Reminiscent
add more test cases
e1709d0
@Reminiscent
Merge branch 'master' of github.com:pingcap/tidb into bindCache
c98de62
@Reminiscent
refactor
7c03a9b
@Reminiscent
fix ut
e64d0a4
@Reminiscent
Merge branch 'master' of github.com:pingcap/tidb into bindCache
fc0c61b
@Reminiscent
address comments
51654d1
@Reminiscent
Merge branch 'master' of github.com:pingcap/tidb into bindCache
4a30196
@Reminiscent
fix ut
8f3f924
@Reminiscent
Merge branch 'master' of github.com:pingcap/tidb into bindCache
c4be048
@Reminiscent
address comments
f6db6e2
@Reminiscent
Merge branch 'master' of github.com:pingcap/tidb into bindCache
f5f3b61
@Reminiscent
export some functions in bind_cache.go and add some comments
bea219e
@Reminiscent
Merge branch 'master' of github.com:pingcap/tidb into bindCache
95b07f1
@Reminiscent
address comments
b8fc473
@Reminiscent
Merge branch 'master' of github.com:pingcap/tidb into bindCache
2e62a66
@Reminiscent
planner: support 'show binding_cache status'
a20e9f2
@Reminiscent
Merge branch 'master' of github.com:pingcap/tidb into ShowBindingCach…
56d0f95 
…eStatus
@Reminiscent Reminiscent requested a review from a team as a code owner February 23, 2022 09:06
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 23, 2022
@Reminiscent Reminiscent reopened this Mar 8, 2022
qw4990
qw4990 reviewed Mar 8, 2022
View reviewed changes
executor/show.go Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Mar 8, 2022
View reviewed changes
executor/show_test.go Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Mar 8, 2022
View reviewed changes
executor/show_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
Reminiscent
Reminiscent commented Mar 10, 2022
View reviewed changes
executor/show.go
func (e *ShowExec) fetchShowBindingCacheStatus(ctx context.Context) error {
exec := e.ctx.(sqlexec.RestrictedSQLExecutor)

rows, _, err := exec.ExecRestrictedSQL(ctx, nil, fmt.Sprintf("SELECT count(*) FROM mysql.bind_info where status = '%s' or status = '%s';", bindinfo.Enabled, bindinfo.Using))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the Disabled status binding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests for Dsiabled= status will be added until the PR #32819 is merged.

time-and-fate
time-and-fate reviewed Mar 14, 2022
View reviewed changes
executor/show.go Outdated
func (e *ShowExec) fetchShowBindingCacheStatus(ctx context.Context) error {
exec := e.ctx.(sqlexec.RestrictedSQLExecutor)

rows, _, err := exec.ExecRestrictedSQL(ctx, nil, fmt.Sprintf("SELECT count(*) FROM mysql.bind_info where status = '%s' or status = '%s' or status = '%s';", bindinfo.Enabled, bindinfo.Using, bindinfo.Disabled))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is it possible that bindings on a single SQL are counted multiple times?
Seems the the logic below only counts the enabled bindings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, a single SQL can only contain one binding at most. Change it to only count the enabled binding.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 71126d1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@ti-chi-bot
Copy link
Member

@Reminiscent: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d79527b into pingcap:master Mar 15, 2022
@Reminiscent Reminiscent deleted the ShowBindingCacheStatus branch March 15, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
epic/sql-plan-management release-note-none sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Reminiscent @ti-chi-bot @sre-bot @qw4990 @time-and-fate