Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: build sessPool even if RunWorker == false #33677

Merged
merged 7 commits into from Apr 2, 2022
Merged

ddl: build sessPool even if RunWorker == false #33677

merged 7 commits into from Apr 2, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Apr 2, 2022 •
edited

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #33676

Problem Summary:
struct ddl doesn't have sessPool if RunWorker == false

What is changed and how it works?

Move the code to make sure build sessPool even if RunWorker == false

Check List

Tests

  • Unit test
  • Integration test
    pass integration-ddl-test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016
done
63021a3 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 2, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@wjhuang2016
Copy link
Member Author

/run-integration-ddl-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 2, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6bdf29e146631f54fe308abceac862a71a8bd896

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 63021a3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2022
@tangenta
Copy link
Contributor

tangenta commented Apr 2, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2022
@hawkingrei
Copy link
Member

/run-check_dev_2

1 similar comment
@hawkingrei
Copy link
Member

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 88cd765 into pingcap:master Apr 2, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33677 to release-4.0
df59cfa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #33692

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33677 to release-5.0
8dba3ca 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33693

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33677 to release-5.1
ad616f8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33694

@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 failed

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33677 to release-5.3
02dae62 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33695

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33677 to release-5.4
adddaee 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33697

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33677 to release-6.0
f297962 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33698

ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2022
@ti-srebot
ddl: build sessPool even if RunWorker == false (#33677) (#33697)
ddd815c 
close #33676
@wjhuang2016 wjhuang2016 deleted the fix_sessionPool branch November 17, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

struct ddl doesn't have sessPool if RunWorker == false
7 participants
@wjhuang2016 @ti-chi-bot @sre-bot @xiongjiwei @tangenta @hawkingrei @ti-srebot